Re: [TSVN] Changes in 2634

On Tue, 08 Feb 2005 11:00:22 +0000, Will Dean <svn@indcomp.co.uk> wrote:

> You missed the point about m_bSVNEntryFieldSet, which is that if it's not
> set, the cache only returns the top of the response structure (just the
> svn_wc_status structure).

I don't think I missed the point here. m_bSVNEntryFieldSet does what
you say. But the method BuildCacheResponse fills out the response data
which is sent back to the shell extension, but doesn't initialize the
data if m_bSVNEntryFieldSet is false. So if m_bSVNEntryFieldSet is
false, uninitialized data is sent to the shell extension, without it
being aware of that!

> I certainly hadn't implemented this part very well at all, so it was most
> unclear from looking in StatusCacheEntry that that's what was going on,
> which is why you were mislead.

> Can I have another -1, then please :-)

You can revert the try-catch block if you want, but please leave the rest in.

Another thing I noted: the whole cache exe doesn't close properly. It
doesn't react to any WM_CLOSE, WM_ENDSESSION, ... messages and
therefore is usually 'killed' by the OS in case of a shutdown/logoff.
Ok, in case of a shutdown this won't really matter, but in case of a
logoff, this can leave memory allocated (mem leak). Also, apr doesn't
really like it if it's not closed properly.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org