Re: [TSVN] Changes in 2634

At 11:25 08/02/2005 +0100, you wrote:

>As you say: _shoud_ be consistent! But you can't be sure here. And I'd
>
>No. I just did a little review and found almost no checks.
>What worried me most was in StatusCacheEntry.cpp::BuildCacheResponse()
>returned invalid pointers and non-terminated strings (not zero
>terminated) if m_bSVNEntryFieldSet was FALSE. That's when I decided to
>add the try-catch block - there might be more of those lying around.

You missed the point about m_bSVNEntryFieldSet, which is that if it's not
set, the cache only returns the top of the response structure (just the
svn_wc_status structure).

I certainly hadn't implemented this part very well at all, so it was most
unclear from looking in StatusCacheEntry that that's what was going on,
which is why you were mislead.

>There's only -1, 0, and +1.

Can I have another -1, then please :-)

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Feb 8 12:01:00 2005