Re: [TSVN] Changes in 2634

At 12:51 08/02/2005 +0100, you wrote:

>I don't think I missed the point here. m_bSVNEntryFieldSet does what
>you say. But the method BuildCacheResponse fills out the response data
>which is sent back to the shell extension, but doesn't initialize the
>data if m_bSVNEntryFieldSet is false. So if m_bSVNEntryFieldSet is
>false, uninitialized data is sent to the shell extension, without it
>being aware of that!

It's NOT sent back, that's the point. It doesn't send the whole response
structure, just the first 32 bytes.

>Another thing I noted: the whole cache exe doesn't close properly. It
>doesn't react to any WM_CLOSE, WM_ENDSESSION, ... messages and
>therefore is usually 'killed' by the OS in case of a shutdown/logoff.
>Ok, in case of a shutdown this won't really matter, but in case of a
>logoff, this can leave memory allocated (mem leak).

Well, it won't respond to WM_ messages, because it doesn't have a message
loop.

I can't see where the memory leak would be, though.

> Also, apr doesn't
>really like it if it's not closed properly.

I'm not sure it would know. (A dead person doesn't have much of an opinion
on his own death...)

I'll tidy this up.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Feb 8 13:01:25 2005