[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: Semantics of --depth: should define WC-depth for omitted-items?

From: Rui, Guo <timmyguo_at_mail.ustc.edu.cn>
Date: Fri, 18 Apr 2008 14:31:14 +0800

On Thu, Apr 10, 2008 at 12:37:01AM +0800, Rui, Guo wrote:
> It shows that the --depth option will define WC-depth for those not exist in
> the wc yet (aka omitted-items). I wrote a test case for it, which is
> gracefully passed. I expect this behavior is consistent in other subcommands
> and thus add a verify_depth(None, "files", new1_path) to check it in the
> "add_tree_with_depth_files" test case. To my surprise, the depth of new
> added
> directory is still infinity. What do you think about this? Do I made a wrong
> assumption or is it actually a bug?
> Anyway, I suggest the description of --depth option in the commandline help
> messages be improved to notify this behavior, at least for the checkout,
> update and switch commands. The new description should looks like this:
> --depth ARG : limit operation by depth ARG ('empty', 'files',
> 'immediates', or 'infinity'), also defines wc
> depth for the items not yet exist in wc
> Also, the sparse-directories.txt should be updated accordingly.

I attached the test case used to verify the behavior of 'svn up --depth=FOO
OMITTED-TREE'. The new verify-depth in "add_tree_with_depth_files" was
commented out since it's still under discussion.

Added test case to verify the semantics of --depth on items that are either
omitted in WC or not yet under version control.

* subversion/tests/cmdline/depth_tests.py
  (pull_in_tree_with_depth_option): New, pull in directory A with
  --depth=immediates, expected to see the depth of A is set to immediates
  (add_tree_with_depth_files): Added a verify_depth() to check the depth of
  the new1_path. Commented out since it's still under discussion
  (depth_fold_expand_clean_trees): Fix a silly bug caused by copy/paste.
  The last expected_status assignment should be expected_disk.


Rui, Guo

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-04-18 08:31:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.