[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Semantics of --depth: should define WC-depth for omitted-items?

From: Rui, Guo <timmyguo_at_mail.ustc.edu.cn>
Date: Fri, 18 Apr 2008 14:52:00 +0800

On Thu, Apr 17, 2008 at 02:18:34PM -0400, C. Michael Pilato wrote:
> >Folks, svn takes the '--depth' option to the other commands besides
> >'checkout' and 'update'. For example, 'svn add --depth=FOO NEWTREE'
> >means:
> >
> > "Add NEWTREE, but only include the parts of it reachable when
> > descending as far as depth FOO from the top."
> >
> >And that is how we behave right now. But the question is, once NEWTREE
> >is under version control, should it be at depth=FOO or depth=infinity?
> >
> >Right now, it's at depth=infinity. While that's useful in some cases, I
> >think it might be more consistent, and more in line with user
> >expectations, for it to be at depth=FOO.
>
> Adding NEWTREE at depth infinity makes sense.
>
> Adding NEWTREE at depth FOO does not necessarily makes sense in the general
> case of using --depth with 'svn add'.
>
> Perhaps there's a middle ground to consider seeking: Adding NEWTREE at
> depth (FOO - (depth from TARGET to FOO). Yes, in the case of 'svn add
> --depth=FOO NEWTREE', that's depth=FOO. But what about 'svn add --force
> --depth=immediates parent=of-NEWTREE' ? Seems in that case you want
> NEWTREE added at depth empty, since that's what left of a depth-immediates
> additive crawl of its parent directory (the actual target of the operation).
Perhaps I didn't correctly get your idea in my previous reply. However, my
reply seems still apply. :-)

Instead of your example:
svn add --force --depth=immediates parent=of-NEWTREE

I tried this instead...
svn add --depth=immediates --parents NEWTREE
In this situation, the depth of intermediate parents is not explicitly
defined, while the depth of the target should be set to immediates. However,
the depth of the intermediate parents can be set to depth-empty according to
the current behavior.

As of your example, I just agree with your expectation. That is reasonable.

Rui, Guo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-18 08:52:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.