[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove extra files in make distclean/extraclean

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-06 14:16:31 CEST

On Thu, Oct 06, 2005 at 12:06:43PM +0100, Max Bowsher wrote:
> Malcolm Rowe wrote:
> >According to the comments for make extraclean and make distclean, the
> >former should return us to before './autogen.sh' was run, and the latter
> >to before './configure' was run.
> >
> >However, there are some generated files that are left behind,
> I've committed a correction to the path of svn_private_config.*, and made
> changes so that configure substitutes an automatically generated list of
> files generated by SVN_CONFIG_SCRIPT into Makefile.

Oh, that's _much_ nicer. I didn't even think of that - nice!

> I've left out the addition of gen-make.opts and config.nice, because it is
> possible that their omission is deliberate, not accidental, as after a
> clean, you might well want to reconfigure with your saved build settings.
> Do you (and anyone else reading this thread) think that gen-make.opts and
> config.nice should be retained, due to the above possible usage, or
> cleaned, so that the cleaning is total?

I'm ambivalent. 'make extraclean' is supposed to take us back to pristine
(prior to autogen.sh), so in theory we should blow them away; but on
the other hand, you point out a valid reason to keep them. (Though note
that ./autogen.sh re-runs gen-make.py [and therefore overwrites
gen-make.opts] anyway, so you'll have to be careful if you did want to
retain gen-make.opts for a later run.)

Hm, while we're here, I think that all the 'make extraclean' targets
need to be prefixed with $(top_srcdir), because currently it'll fail
for VPATH builds (though the concept of 'make extraclean' is a bit dubious
for a VPATH build anyway, I guess).

> >[and these two directories, created by 'make mkdir-init'
> >subversion/bindings/java/javahl/classes/
> >subversion/bindings/java/javahl/include/]
> >I've not added the two javahl directories because
> >I couldn't see any obvious place to remove them (and I don't build the
> >java bindings, so I'd have no way to properly test such a change),
> That's fair - I don't build the javahl bindings either - let's leave that
> matter up to those with experience in that area.

Actually, in extraclean, we should probably just remove _all_ the
directories that 'make mkdir-init' can create (and that are also empty),
because that way we'd clear up VPATH builds completely. Perhaps we should
create a 'rmdir-init' companion to 'mkdir-init'?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 6 14:18:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.