[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix 'make extraclean' for VPATH builds

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-07 12:51:23 CEST

On Thu, Oct 06, 2005 at 01:16:31PM +0100, Malcolm Rowe wrote:
> Hm, while we're here, I think that all the 'make extraclean' targets
> need to be prefixed with $(top_srcdir), because currently it'll fail
> for VPATH builds (though the concept of 'make extraclean' is a bit dubious
> for a VPATH build anyway, I guess).

See attached patch, which does just that. If we're not going to disallow
'make extraclean' for VPATH builds, we might as well fix it to delete
the files from the correct location.

I also noticed that we no longer need to remove ac-helpers/ltconfig,
since it no longer exists (it dates from libtool 1.3, pre-r212), so the
patch also removes that from the list of files to delete and removes it
from svn:ignore in ac-helpers/. I realise that this could be considered
to be combining two separate changes, but they're both in exactly the
same area and it seemed to me that splitting them would be completely
over-the-top, even to someone as anal as myself.

[The property change to svn:ignore will have to be applied manually, of
course, but there didn't seem any harm in leaving the text in the patch.]

[[[
* Makefile.in
  (local-extraclean): Fix 'make extraclean' in a VPATH build: remove
    generated files from the srcdir, where they are, not the build dir, where
    they're not. Also, stop trying to remove ac-helpers/ltconfig, which
    hasn't been generated since before r212.

* ac-helpers/
  Remove 'ltconfig' from the svn:ignore list.
]]]

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Oct 7 12:52:16 2005

This is an archived mail posted to the Subversion Dev mailing list.