[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove extra files in make distclean/extraclean

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-06 13:06:43 CEST

Malcolm Rowe wrote:
> According to the comments for make extraclean and make distclean, the
> former should return us to before './autogen.sh' was run, and the latter
> to before './configure' was run.
>
> However, there are some generated files that are left behind,
...
> I've attached a patch that adds most of these files to the relevant
> parts of Makefile.in.
...
> * Makefile.in
> (fast-distclean): Add config.nice, correct the path used for
> subversion/svn_private_config.h, and add all the outstanding files
> generated by SVN_CONFIG_SCRIPT in ./configure.in.
> (local-extraclean): Add gen-make.opts, and correct the path used for
> subversion/svn_private_config.h.in.

I've committed a correction to the path of svn_private_config.*, and made
changes so that configure substitutes an automatically generated list of
files generated by SVN_CONFIG_SCRIPT into Makefile.

I've left out the addition of gen-make.opts and config.nice, because it is
possible that their omission is deliberate, not accidental, as after a
clean, you might well want to reconfigure with your saved build settings.

Do you (and anyone else reading this thread) think that gen-make.opts and
config.nice should be retained, due to the above possible usage, or cleaned,
so that the cleaning is total?

This means the remaining files not handled are:
> For 'make extraclean' (which cleans files generated by ./autogen.sh):
> gen-make.opts
> [a bunch of .pyc files under build/]
>
> For 'make distclean' (which cleans files generated by ./configure):
> config.nice
> [and these two directories, created by 'make mkdir-init'
> subversion/bindings/java/javahl/classes/
> subversion/bindings/java/javahl/include/]

> I've not added the two javahl directories because
> I couldn't see any obvious place to remove them (and I don't build the
> java bindings, so I'd have no way to properly test such a change),

That's fair - I don't build the javahl bindings either - let's leave that
matter up to those with experience in that area.

> and
> I've not added the .pyc files, because, again, I'm not entirely sure where
> to clear them up (or even what they are - compiled python bytecode?).

Yes, compiled python bytecode. They are harmless, so I'm not really
concerned about them, but I think extraclean would probably be a reasonable
place to delete them from.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 6 13:08:18 2005

This is an archived mail posted to the Subversion Dev mailing list.