[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove extra files in make distclean/extraclean

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-07 02:16:27 CEST

On Thu, 06 Oct 2005, Malcolm Rowe wrote:

> On Thu, Oct 06, 2005 at 12:06:43PM +0100, Max Bowsher wrote:
> > I've left out the addition of gen-make.opts and config.nice, because it is
> > possible that their omission is deliberate, not accidental, as after a
> > clean, you might well want to reconfigure with your saved build settings.
> >
> > Do you (and anyone else reading this thread) think that gen-make.opts and
> > config.nice should be retained, due to the above possible usage, or
> > cleaned, so that the cleaning is total?
> I'm ambivalent. 'make extraclean' is supposed to take us back to pristine
> (prior to autogen.sh),

I've heard almost the same thing verbatim from other developers.

> so in theory we should blow them away; but on
> the other hand, you point out a valid reason to keep them. (Though note
> that ./autogen.sh re-runs gen-make.py [and therefore overwrites
> gen-make.opts] anyway, so you'll have to be careful if you did want to
> retain gen-make.opts for a later run.)
Blowing away config.nice is kinda annoying (this has bitten me before -- I
save off a copy of it now), but is probably the Right thing to do from a
correctness standpoint.

> Hm, while we're here, I think that all the 'make extraclean' targets
> need to be prefixed with $(top_srcdir), because currently it'll fail
> for VPATH builds (though the concept of 'make extraclean' is a bit dubious
> for a VPATH build anyway, I guess).
> > >[and these two directories, created by 'make mkdir-init'
> > >subversion/bindings/java/javahl/classes/
> > >subversion/bindings/java/javahl/include/]
> >
> > >I've not added the two javahl directories because
> > >I couldn't see any obvious place to remove them (and I don't build the
> > >java bindings, so I'd have no way to properly test such a change),
> >
> > That's fair - I don't build the javahl bindings either - let's leave that
> > matter up to those with experience in that area.
distclean should be blowing away both of those directories. Even clean
should probably be blowing them away.

> Actually, in extraclean, we should probably just remove _all_ the
> directories that 'make mkdir-init' can create (and that are also empty),
> because that way we'd clear up VPATH builds completely. Perhaps we should
> create a 'rmdir-init' companion to 'mkdir-init'?

You're likely right.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 7 02:15:47 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.