[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-07-22 20:36:22 CEST

David James wrote:

> Thanks for your updated patch!
>
>
>>Log Message:
>>Load a crash reporting dll on Windows when clients start up.
>>subversion/libsvn_subr/cmdline.c : load the crashrpt.dll dynamically
>
> Can you provide a little more detail? Please outline the changes you
> made to each function.

Load a crash reporting dll on Windows when clients start up.
* subversion/libsvn_subr/cmdline.c(svn_cmdline_init):
   load the crashrpt.dll dynamically

There's not much more to say because that's all the code does. The rest
is done by the crashrpt.dll itself (catching exceptions, showing the
dialog, sending the mail with the zipped crashdump).

> It looks like you're still using Hungarian naming conventions. Is it
> possible to fix this?

The names of the functions are the same as used in the dll. I don't
think it's a good idea to change the name (would that even work?) or the
param names (that would work).

Besides that: I know it's easier for you guys to just tell me what you
like to have changed in the patch and me then doing the whole work. But
the patch works, and all you now might want to change are very little
things (or reject the patch completely). So I think if you really want
this, you should just change those little things yourself.
I'm doing that too if people send patches for TortoiseSVN - I don't pick
on every little thing I'm not comfortable with but just change it myself.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 20:37:20 2005

This is an archived mail posted to the Subversion Dev mailing list.