[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: <kfogel_at_collab.net>
Date: 2005-07-22 21:02:29 CEST

SteveKing <steveking@gmx.ch> writes:
> Besides that: I know it's easier for you guys to just tell me what you
> like to have changed in the patch and me then doing the whole
> work. But the patch works, and all you now might want to change are
> very little things (or reject the patch completely). So I think if you
> really want this, you should just change those little things yourself.
> I'm doing that too if people send patches for TortoiseSVN - I don't
> pick on every little thing I'm not comfortable with but just change it
> myself.

When there are only little nits left, I think it is our usual practice
to both commit the patch (making the tweaks ourselves) *and* tell the
original submitter what needed to be changed, so he knows for next
time.

But fixing up a log message can actually be rather laborious. You
have to apply the patch, then go into the source code, figure out an
English description of each change, and write it up. Don't be
surprised when we bounce that back to the submitter, who can do it a
lot faster. We rely on that sort of parallelization; without it,
every maintainer's time would be taken up with patch and log message
adjustment.

It's nice that you do that extra work for TortoiseSVN, but unless
TSVN's patch reception and incorporation rates are similar to
Subversion's, it's not a useful comparison, I think.

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 21:54:10 2005

This is an archived mail posted to the Subversion Dev mailing list.