[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-07-22 20:30:06 CEST

On Fri, 2005-07-22 at 12:06 -0600, Michael W Thelen wrote:
> But if svn log output is intended to allow exact reconstruction of the
> original log message, including ending newlines, then you are right.

There's another, admittedly more subtle way of looking at this:

  * The log message is a sequence of lines.

  * The svn:log property gives the log message, with the exception that
if svn:log does not end in a newline, then it is ever so slightly
corrupt. In this case, "svn log" will correct for that (the log message
becomes the svn:log property plus a newline) because historically, we
haven't enforced that constraint.

  * The client will ensure that svn:log values end in a newline when new
revisions are committed and when "svn propset" is done. (Will the
server also enforce this constraint? I'm not sure; how much enforcement
do we do on other svn: properties?)

Obviously, I am describing some hypothetical future Subversion, not the
current one.

> So the question becomes: is svn log output intended for nice display,
> or is it intended to allow exact reconstruction of the log message?

In this view, "svn log" gives the exact log message, but not always the
exact value of the svn:log property. For that you use svn propget
--revprop --strict svn:log.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 20:32:01 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.