Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

Madan U Sreenivasan wrote:
> On Wed, 2005-03-09 at 22:54, Julian Foad wrote:
>>Madan U Sreenivasan wrote:
> [...]
>>> * subversion/libsvn_wc/subst.h
>>> Added comment to refer to svn_canonicalize_keywords()
>>> in props.c
>>
>>You should name the item that is affected:
>>
>> (svn_subst_keywords_t): Added comment to refer to
>> svn_canonicalize_keywords() in props.c
>
> But svn_subst_keywords_t is not related to svn_canonicalize_keywords()
> .... :-? bigger question is which part of the .h, should I add a NOTE
> that is only a pointer to another file and not related to any part of
> the .h itself....

If svn_subst_keywords_t is not related to svn_canonicalize_keywords(), then why
did you put the comment adjacent to the definition of that type? Perhaps the
comment should instead go where SVN_KEYWORD_... are defined.

- Julian

-- 
http://www.foad.me.uk/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org