Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

On Wed, 2005-03-09 at 22:54, Julian Foad wrote:
> I just have some comments on formatting, for the C code, and a couple of
> comments about the Python tests.
>
> Madan U Sreenivasan wrote:
[...]
> > * subversion/libsvn_wc/subst.h
> > Added comment to refer to svn_canonicalize_keywords()
> > in props.c
>
> You should name the item that is affected:
>
> (svn_subst_keywords_t): Added comment to refer to
> svn_canonicalize_keywords() in props.c
>
> [...]

But svn_subst_keywords_t is not related to svn_canonicalize_keywords()
.... :-? bigger question is which part of the .h, should I add a NOTE
that is only a pointer to another file and not related to any part of
the .h itself....

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 10 08:10:53 2005