[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-03-11 08:57:27 CET

On Thu, 2005-03-10 at 19:30, Julian Foad wrote:
> Madan U Sreenivasan wrote:
> > On Wed, 2005-03-09 at 22:54, Julian Foad wrote:
> >>Madan U Sreenivasan wrote:
> > But svn_subst_keywords_t is not related to svn_canonicalize_keywords()
> > .... :-? bigger question is which part of the .h, should I add a NOTE
> > that is only a pointer to another file and not related to any part of
> > the .h itself....
> If svn_subst_keywords_t is not related to svn_canonicalize_keywords(), then why
> did you put the comment adjacent to the definition of that type? Perhaps the
> comment should instead go where SVN_KEYWORD_... are defined.
 oh, rest of the code that use the #define reside in subst.c. So, I
wanted a comment in svn_subst.h to point to props.c mentioning that the
#defines are used there too ( this is in case someone decides to add a
new keyword in future ). This was John's suggestion too.
 Now, regarding the location of the comment in svn_subst.h, I was not
too sure... thats why I put it near 'related' code...
 On the other hand, svn_types.h is a better place to put this.... but I
was not sure about touching a file as widely used as svn_types.h for
commenting.... anyways, since you suggested it too, I think I will go
ahead and put this comment in svn_types.h....


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 11 08:51:48 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.