[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Review 1.2 API changes

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-14 21:30:06 CET

Since API changes can get us in a bit of a mess if we are not careful, I would
like to review the changes that we are going to make for version 1.2.

I will give a summary of the changes, grouped by type of change, and then we
can consider and discuss the changes in each group. There is one additional
issue on which I include notes, and that is the desire to change from Boolean
"recurse" to integer "depth" arguments.

Grep "@since.*1\.2" (Does anyone have a quick way to find API changes without
relying on the "@since" comment having been added?)

+/-/=/! means added/deleted/same/different. My comments are in parentheses.

# Add peg revision.

svn_client_blame2
   + const svn_opt_revision_t *peg_revision

svn_client_propget2
   + const svn_opt_revision_t *peg_revision
   = svn_boolean_t recurse
   (Not all callers changed)

svn_client_proplist2
   + const svn_opt_revision_t *peg_revision
   = svn_boolean_t recurse

svn_client_export3
   + svn_opt_revision_t *peg_revision
   (Not const?)
   (No recurse option.)
   (Not all callers changed from svn_client_export.)

svn_client_ls2
   + svn_opt_revision_t *peg_revision
   (Not const?)
   = svn_boolean_t recurse
   (tools/examples/minimal_client.c not updated.)

svn_client_cat2
   + const svn_opt_revision_t *peg_revision
   (Existing comment: ### TODO: Add an expansion/translation flag?)

# Miscellaneous.

svn_opt_args_to_target_array2
   - svn_opt_revision_t *start_revision,
   - svn_opt_revision_t *end_revision,
   - svn_boolean_t extract_revisions,

svn_client_move2
   - const svn_opt_revision_t *src_revision

svn_errno_t
   + SVN_ERR_WC_INVALID_SCHEDULE "Invalid schedule"
   ("@since" comment is not a Doxygen comment.)

svn_wc_adm_open_anchor
   (New function.)

# Allow setting of a property value that the client considers invalid.

svn_client_propset2
   + svn_boolean_t force
   = svn_boolean_t recurse,

svn_wc_prop_set2
   + svn_boolean_t force

# Diff prop changes with dir/file changes.

svn_wc_diff_callbacks2_t
   (Big change.)

svn_wc_get_diff_editor3
   ! const svn_wc_diff_callbacks2_t *callbacks
   = svn_boolean_t recurse

svn_wc_diff3
   ! const svn_wc_diff_callbacks2_t *callbacks
   = svn_boolean_t recurse

# New "limit" argument for "log" command.

svn_client_log2
   + unsigned int limit

svn_ra_plugin_t
   + get_log2 (with "limit", as in svn_client_log2)
   (This is added to the end of the existing structure.)
   (Do we need to document what to set 'get_log' and 'get_log2' to? Should one
of them be NULL, or both be usable functions?)

svn_repos_get_logs3
   + unsigned int limit
   (Previous version doesn't document the difference.)

svn_ra_dav__get_log2
   (Undocumented.)
   (Private, so doesn't need "@since"?)

svn_ra_local__get_log2
   (Undocumented.)
   (Private, static, so doesn't need "@since"?)

ra_svn_log2
   (Undocumented.)
   (Private, static, so doesn't need "@since"?)

All of these replace an older version and mark it as deprecated, except
svn_wc_adm_open_anchor which is new, svn_errno_t::SVN_ERR_WC_INVALID_SCHEDULE
which is a new constant added compatibly to its enum, and
svn_ra_plugin_t::get_log2 which is a new member added compatibly to its struct.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 14 21:30:59 2004

This is an archived mail posted to the Subversion Dev mailing list.