Re: Review 1.2 API changes - add peg revision

Julian Foad wrote:
> # Add peg revision.

Josh Pieper, this is your area. Are you willing to make the changes below?

I also may have some concerns about the choosing of default values in these new
APIs, and the command-line interface for peg revisions, but I will raise those
separately.

>
> svn_client_blame2
> + const svn_opt_revision_t *peg_revision
>
> svn_client_propget2
> + const svn_opt_revision_t *peg_revision
> = svn_boolean_t recurse
> (Not all callers changed)

All callers should use the new version, as it would be rude to expect other
people to stop using the deprecated function if we continue to use it ourselves.

> svn_client_proplist2
> + const svn_opt_revision_t *peg_revision
> = svn_boolean_t recurse
>
> svn_client_export3
> + svn_opt_revision_t *peg_revision
> (Not const?)

Add "const" (unless there is a good reason not to).

> (No recurse option.)
> (Not all callers changed from svn_client_export.)

Change the callers.

>
> svn_client_ls2
> + svn_opt_revision_t *peg_revision
> (Not const?)

Add "const".

> = svn_boolean_t recurse
> (tools/examples/minimal_client.c not updated.)

Not essential, but it would be really good to update that example.

>
> svn_client_cat2
> + const svn_opt_revision_t *peg_revision
> (Existing comment: ### TODO: Add an expansion/translation flag?)

There's no urgent need to address this TODO right now, as it isn't part of the
change from 1.1 to 1.2, but it would be nice to decide whether we are going to
do it and not have the "###" comment in the code.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 15 20:41:21 2004