[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review 1.2 API changes - log --limit

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-14 23:54:17 CET

Julian Foad wrote:
> # New "limit" argument for "log" command.

This seems fine except for two things:

* We really, really should not use "unsigned" in the interface. I recommend
reverting r11162 which converted various arguments to unsigned.

Just now I tried "svn log --limit=-5" and it listed all revisions. r11162 did
not solve that problem, and indeed it introduced signed/unsigned mismatches.
Compilers can warn about signed/unsigned mismatches, but they are a necessary
evil in many places so the potential to be warned about them isn't often an
actual benefit.

* A few small documentation issues, as noted below.

- Julian

> svn_client_log2
> + unsigned int limit
>
> svn_ra_plugin_t
> + get_log2 (with "limit", as in svn_client_log2)
> (This is added to the end of the existing structure.)
> (Do we need to document what to set 'get_log' and 'get_log2' to?
> Should one of them be NULL, or both be usable functions?)

I think it would be worth stating what the requirement is in that regard.

>
> svn_repos_get_logs3
> + unsigned int limit
> (Previous version doesn't document the difference.)

We normally say in the deprecated version's doc string, "Same as [new version]
except [whatever is different]".

>
> svn_ra_dav__get_log2
> (Undocumented.)
> (Private, so doesn't need "@since"?)
>
> svn_ra_local__get_log2
> (Undocumented.)
> (Private, static, so doesn't need "@since"?)
>
> ra_svn_log2
> (Undocumented.)
> (Private, static, so doesn't need "@since"?)

These last three probably don't need any doc string, as they can easily be
traced to svn_ra_plugin_t::get_log2.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 14 23:54:53 2004

This is an archived mail posted to the Subversion Dev mailing list.