[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review 1.2 API changes - "bool recurse" vs. "int depth"

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-15 17:06:35 CET

Julian Foad wrote:
> There is
> one additional issue on which I include notes, and that is the desire to
> change from Boolean "recurse" to integer "depth" arguments.

I was thinking that whenever we are changing a function's signature, maybe we
should take the opportunity to change "bool recurse" to "int depth", even if
the function does not yet implement depths other than (1 or 0) and infinity.

Or, more probably, we should change all of the APIs that currently take "bool
recurse".

The only benefit I can see is that a client can then be built that supports a
UI for specifying depth, and it will be able to run with this 1.2 API (failing
at run-time for certain depth arguments) and won't have to be upgraded as and
when we do make these library functions support other depths.

I don't feel strongly about this. Do you think that is worth doing? Can you
see any other pros or cons?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 15 17:07:06 2004

This is an archived mail posted to the Subversion Dev mailing list.