Re: Review 1.2 API changes

Julian Foad wrote:
> Grep "@since.*1\.2" (Does anyone have a quick way to find API changes
> without relying on the "@since" comment having been added?)

You missed the changes to svn_subst_copy_and_translate2() which support the
special file handling. As Brane (I believe) suggested, a diff between the trunk
and the last release is probably better than grep'ing (though it would be nice
to go back and make sure that the appropriate @since was added).

This brings up a point I was hoping to broach soon anyways:

Is there any chance I could get the keywords-as-hash code added to the 1.2
release? The reason I ask is that there are a couple of signature changes
(specifically the one I mentioned above) which will require another
compatibility layer if it is implemented later, and it seems silly to have
svn_subst_copy_and_translate3() if we don't have to.

The codebase has wandered quite far from where it was when I submitted my last
patches, but I have some time this week (I'm on medical leave) to bring them up
to date. I'm going to withdraw the third part (which allowed for custom
keywords from properties) until such time as I can get a good proposal for
inherited properties written up (that may also be something I can do this week)
and, more importantly, agreed upon as a way to proceed.

I'm pitching the keywords-as-hash concept as currently a way to future proof the
code; it becomes much easier to add new aliases and keywords in the future if we
aren't dealing with a struct any longer.

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org