[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Authorization..

From: Emre Uslu <emreu_at_ayesas.com>
Date: Fri, 11 Apr 2008 18:48:30 +0300

Thanks Holger.

Actually i do not keep the file after review. The only difference i saw
in your flow is reviewers may commit the file to the branch instead they
give their comments via mail. I thought to delete the file if it is
rejected but i do not thought enough about the comments.

But if the reviewers may be out of the group they may not be commit the
file to the branch as the only committers are the members of the group.
So either i should extend the group with the reviewers or i should
extend the right of tag folder as writeable for reviewers. Both of that
is confusing..

Anyway your flow about reviewers may be useful. Thank you...

EMRE USLU

>-----Original Message-----
>From: Holger Stratmann [mailto:tigris_at_finch.de]
>Sent: Wednesday, April 09, 2008 6:38 PM
>To: Emre Uslu
>Cc: Subversion Mailing List
>Subject: Re: Authorization..
>
>Emre Uslu wrote:
>> These users put and modify documents in a folder under branches and
when
>> documents are ready for review they put it to another folder under
tags.
>> If the reviewer thinks that document is not appropriate, they should
>> continue working on the folder under branches. But some users are
>> modifying the documents under tags folder by mistake. That's why I
want
>> to permit modifying the files under the tags folder.
>>
>> EMRE USLU
>You probably don't want to hear that, but this workflow is wrong... You
>"tag" something when it's done and you want to keep it, i.e. AFTER the
>review.
>
>The way you're doing it, you have many documents under "tags" that did
>not pass the review - this can also be confusing for other people who
>just want to access the documents... Do you delete the documents when
>they are rejected? And then what happens to the "next version" if the
>user is not allowed to modify the previous document under "tags"? Is
>every version saved under a new name?! That's not really how a version
>control system is used...
>
>Suggestion: Users work on documents under "branches" and ask for a
>review when they think it's appropriate.
>The reviewer can review documents and also make changes or remarks if
>he/she wants to do that.
>When the review passed ok, the reviewer copies the document to the tags
>folder (by using svn copy, so it keeps its history from the branch...).
>This means: All "work" happens in a branch. When the work is done, you
>create a tag.
>
>
>Regards,
>
>Holger

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-04-11 17:46:59 CEST

This is an archived mail posted to the Subversion Users mailing list.