Size of TSVN msi installer, need your opinion

Hi,

Because the c-runtime merge modules provided by Microsoft with VS2015
are completely broken (you've noticed that if you installed 1.9.0 x64 -
you had to also install the runtime separately), I've changed the TSVN
build for 1.9.1 to statically link with the c-runtime.
That actually lead to a small size reduction of the installer msi.

But linking the c-runtime statically lead now to other problems:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3136728

That's because the c-runtime keeps global state memory for every dll
separately. This unfortunately includes output to stdout, for which
there is no workaround.

So now I could change the TSVN build to link *everything* statically,
getting rid of the apr/svn dlls. But that means that every exe now
increases in size. Especially all the command line exe (svn, svnadmin,
svnserve, svnversion, ...).

This would fix all the problems that arise if the c-runtime is linked
statically to multiple dlls - because we wouldn't use separate dlls anymore.

But of course, that doubles the size of the msi installer.

1.9.0 32-bit : 15.8MB
1.9.0 64-bit : 20.3MB

fully static link:
32-bit : 30.8MB
64-bit : 39.2MB

So the 64-bit msi is almost 40MB in size now.

So, what should I do?

Link everything statically and have the msi use almost 40MB for a download?
Or go back to linking dynamically to the c-runtime, but not include the
merge modules (as I said: they're broken). That would require that all
users install the c-runtime distributable manually. If the runtime is
not installed, then TSVN would throw errors and would not start.

Opinions?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3137220
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].