[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r24370 committed - Improve space/tab inconsistency detection:...

From: Oto BREZINA <brezina_at_printflow.eu>
Date: Fri, 14 Jun 2013 17:48:22 +0200

On 2013-06-14 17:13, Stefan Küng wrote:
> On 13.06.2013 21:11, Oto BREZINA wrote:
>> r24370:
>> It detect tabs even after first non space/tab character - that will not
>> be converted (intentionaly) so offer is not adequate. Same for spaces.
> haven't checked that part of the code. So you're saying that only
> leading tabs/spaces are converted but not if they're in the middle of
> the line?
> That's seems pretty useless to me, so I'm wondering why this was
> intentional?
Best suited style for us is indent by tabs allign by spaces (I'm not
going to explain).
We are keeping T-Merge not language aware - that good - but there are
languages when tab is in text in not escaped form but indentation is by

Lets call fixing indentation spaces tabs level 1.
And thole line level 2 tools.
> I agree tri-state config was a little bit confusing but coverted 98% of
> cases if you understand it, now I get under 50%.
> I'm starting to wonder whether it's a good idea to even check and ask
> the user to fix these. It would be easier to just have buttons in the
> ribbon/toolbar to fix whatever needs to be fixed and have the user
> execute those manually if needed.
> That way the whole detection logic can be removed since I'm pretty sure
> it won't work in *all* situations, no matter how good we can make it.
> I have used a lot of IDE's and editors, and the ones that fix stuff
> automatically I stopped using because they mess things up without me
> noticing immediately (yes, sometimes I *need* a space at the end of a
> line). The ones that always ask to fix something I either configure to
> never do that again or I rarely use them anymore - too annoying.
> I use however those frequently that have the commands to fix stuff but I
> can do that manually - I know myself if something needs fixing.
As I wrote earlier some statuses (status bar - prefferably clickabel,
ribbon, toolbar) would be great, but I was affraid about proccessing
needed to keep them reasonably actual.
Just note: detection is to help when using commands from context menu too.

Ok lets remove auto fix stuff, commands are in context menu (in first
level only for a moment a I don't see level 2 to be safe).

Whole auto fixing was to get as close to #479 as possible.



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-14 17:48:30 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.