[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r24360 committed - WhiteSpace-Fix handling:...

From: Oto BREZINA <brezina_at_printflow.eu>
Date: Fri, 14 Jun 2013 18:01:33 +0200

On 2013-06-14 17:07, Stefan Küng wrote:
> On 13.06.2013 21:41, Oto BREZINA wrote:
>> On 2013-06-13 20:57, Stefan Küng wrote:
>>> On 13.06.2013 09:29, Oto BREZINA wrote:
>>>> To make it less complex we may add some notification in view title, or
>>>> status bar, but it may require lot of processing or very good design.
>>>> Lets stick we current approach for a while.
>>>> In spaces and tabs conversion it become even more complex.
>>>> Your left file may be all space indented and saving file all tabs. Is
>>>> this correct or not ? In current implementation it is correct as it is
>>>> self homogeniuos.
>>> When doing such fixing, the views have to be handled completely
>>> independent of each other. Why would the left view have anything to do
>>> with how the right view is saved? Doesn't make any sense to me and IMHO
>>> would make things just unnecessarily complicated. And if it's
>>> complicated, the users also won't understand why sometimes it asks to
>>> fix and sometimes not.
>> Few months ago you stand on T-Merge is diff tool where right is editable
>> output and left is source.
>> I consider left as source thing in MOST cases so can be good source of
>> expected tab/spaces style.
>> File on load may be damaged by others editing tools (settings), and
>> T-Merge as last station before commit can warning you that you are about
>> to change that style.
>> This wont solve fixing left file though.
> What does that have to do with keeping the views separate?
> I never said that this fixing should only work for one view. I said that
> fixing one view has nothing to do with any other view that's visible or
> loaded.
I'm not going deeper here there is no sense in that.

Just: not long ago T-Merge philosofy was Left is source, right is
target/edit (in diff). Using this : formating left is more possible
proper format according repository style against right one.
e.g. you are diffing .rc file where spaces are on line ends, T-Merge can
see it is that way on repository, so will offer to fix it. But if you
indent by tabs it can detect it ...
That's all I meant. Maybe it was incorrect deduction but it worked in my

> Stefan


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-14 18:01:39 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.