Re: [tortoisesvn] r24370 committed - Improve space/tab inconsistency detection:...

On 13.06.2013 21:11, Oto BREZINA wrote:
> On 2013-06-13 19:21, tortoisesvn_at_googlecode.com wrote:
>> Revision: 24370
>> Author: tortoisesvn
>> Date: Thu Jun 13 10:21:40 2013
>> Log: Improve space/tab inconsistency detection:
>> * only if there are consecutive spaces to match a tab is the file marked as
>> using spaces
>> * only if there are tabs is the file marked as using tabs
>> * only if both tabs and spaces are used is the file marked as space/tab
>> inconsistent.
>
> While reading this keep in mind I don't want nor meant to attack in any way.
> However I don't know what this revision improved over let say r24355.
> I thought "fix before save" will be simple improvement over manual
> invocation, but seems its getting over us.
>
> r24370:
> It detect tabs even after first non space/tab character - that will not
> be converted (intentionaly) so offer is not adequate. Same for spaces.

haven't checked that part of the code. So you're saying that only
leading tabs/spaces are converted but not if they're in the middle of
the line?
That's seems pretty useless to me, so I'm wondering why this was
intentional?

> e.g.
> 1. our line formating as follow"<tab><tab>Call()<few spaces>// make a
> call" will offer tab->spaces
> 2. space indented line "<8 spaces>Indent "<tab>" // will offer spaces->tab
> one line with two tabs and other with 8 spaces offers BOTH on save!
>
> If there is one space between two tabs, If will not help me to clean it
> up anymore
> If both tabs and spaces are used I get convert tabs to spaces (I preffer
> tabs) no way to configure anymore.
>
> I agree tri-state config was a little bit confusing but coverted 98% of
> cases if you understand it, now I get under 50%.

I'm starting to wonder whether it's a good idea to even check and ask
the user to fix these. It would be easier to just have buttons in the
ribbon/toolbar to fix whatever needs to be fixed and have the user
execute those manually if needed.

That way the whole detection logic can be removed since I'm pretty sure
it won't work in *all* situations, no matter how good we can make it.

I have used a lot of IDE's and editors, and the ones that fix stuff
automatically I stopped using because they mess things up without me
noticing immediately (yes, sometimes I *need* a space at the end of a
line). The ones that always ask to fix something I either configure to
never do that again or I rarely use them anymore - too annoying.
I use however those frequently that have the commands to fix stuff but I
can do that manually - I know myself if something needs fixing.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3058086
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].