[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r24370 committed - Improve space/tab inconsistency detection:...

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 14 Jun 2013 18:45:52 +0200

On 14.06.2013 17:48, Oto BREZINA wrote:

>> haven't checked that part of the code. So you're saying that only
>> leading tabs/spaces are converted but not if they're in the middle of
>> the line?
>> That's seems pretty useless to me, so I'm wondering why this was
>> intentional?
> Best suited style for us is indent by tabs allign by spaces (I'm not
> going to explain).

have a look at my tabspace tool:

it works as I think you want it: using tabs but then spaces to align to
mid-tab positions.
And it does this not just at the beginning of lines but for all tabs/spaces.

>> I agree tri-state config was a little bit confusing but coverted 98% of
>> cases if you understand it, now I get under 50%.
>> I'm starting to wonder whether it's a good idea to even check and ask
>> the user to fix these. It would be easier to just have buttons in the
>> ribbon/toolbar to fix whatever needs to be fixed and have the user
>> execute those manually if needed.
>> That way the whole detection logic can be removed since I'm pretty sure
>> it won't work in *all* situations, no matter how good we can make it.
>> I have used a lot of IDE's and editors, and the ones that fix stuff
>> automatically I stopped using because they mess things up without me
>> noticing immediately (yes, sometimes I *need* a space at the end of a
>> line). The ones that always ask to fix something I either configure to
>> never do that again or I rarely use them anymore - too annoying.
>> I use however those frequently that have the commands to fix stuff but I
>> can do that manually - I know myself if something needs fixing.

> As I wrote earlier some statuses (status bar - prefferably clickabel,
> ribbon, toolbar) would be great, but I was affraid about proccessing
> needed to keep them reasonably actual.
> Just note: detection is to help when using commands from context menu too.

detection is nice, yes. But it's not necessary: you can still have a
command button enabled but when clicked doesn't change anything.

> Ok lets remove auto fix stuff, commands are in context menu (in first
> level only for a moment a I don't see level 2 to be safe).



   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-14 18:46:02 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.