[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - suspicious ownership, too wide scope

From: Dmitry <wipedout_at_yandex.ru>
Date: Thu, 14 Apr 2011 10:27:34 +0400


I see no serious problems now, yet employing auto_buffer would still be a good idea. Patch follows.

Best wishes.

13.04.11, 22:25, "Stefan Küng" <tortoisesvn_at_gmail.com>:

> On 13.04.2011 11:38, Dmitry wrote:
> > Hey.
> >
> > Attached is a patch that addresses suspiciuos stuff.
> >
> > First, an array is created with new[], then not released. Is its owndership passed somewhere? I've lloked into MSDN and didn't find any confirmation for that, still not sure, maybe I'm wrong.
> >
> > Then, an array is created with new[], then released with delete[] - there's a wrapper for that. Finally, some decalarations are suboptimally placed.
> Ups, I rewrote that part before I checked your patch. Sorry.
> But I'd appreciate it if you could review my changes.
> Stefan


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-04-14 08:27:46 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.