[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - suspicious ownership, too wide scope

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 13 Apr 2011 20:25:49 +0200

On 13.04.2011 11:38, Dmitry wrote:
> Hey.
> Attached is a patch that addresses suspiciuos stuff.
> First, an array is created with new[], then not released. Is its owndership passed somewhere? I've lloked into MSDN and didn't find any confirmation for that, still not sure, maybe I'm wrong.
> Then, an array is created with new[], then released with delete[] - there's a wrapper for that. Finally, some decalarations are suboptimally placed.

Ups, I rewrote that part before I checked your patch. Sorry.
But I'd appreciate it if you could review my changes.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-04-13 20:26:16 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.