Re: [PATCH/RFC] Improve log dialog filter tooltip handling

Alexander Klenin wrote:
> * Make CBalloon::Pop function public and document it.
> * Remove anchor from tooltip balloon since it may obstruct filter text
> * Hide tooltip when displaying filter popup menu
> * Simplify popup selection processing code
> * Do not refresh log if user dismissed filter popup menu without
> selecting anything

Thanks for the patch!
Committed in revision 10496.

> I am not sure whether Pop() function is always safe to call, please review.

It's safe to call for 'normal' tooltips. For dialog balloons (i.e., the
ones which have a close button) it is *not* good to call Pop() because
for those, the window also must be destroyed. But since we don't use
those in the log dialog, it's safe to call Pop().

> Also, would it be useful to add BALLOON_BORDER_ANCHOR (or some other
> name?) style to locate balloon so that anchor would point to the
> control border instead of mouse position?
> It seems overkill to do so only for this particular usage, but perhaps
> there are other places where if would be an improvement?

That would definitely be an improvement. And there are other places
where this could be an improvement (everywhere the tooltip is shown for
an edit box, some of those are in the settings dialogs).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org