[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH/RFC] Improve log dialog filter tooltip handling

From: Alexander Klenin <klenin_at_gmail.com>
Date: 2007-09-03 20:02:54 CEST

* Make CBalloon::Pop function public and document it.
* Remove anchor from tooltip balloon since it may obstruct filter text
* Hide tooltip when displaying filter popup menu
* Simplify popup selection processing code
* Do not refresh log if user dismissed filter popup menu without
selecting anything

I am not sure whether Pop() function is always safe to call, please review.
Also, would it be useful to add BALLOON_BORDER_ANCHOR (or some other
name?) style to locate balloon so that anchor would point to the
control border instead of mouse position?
It seems overkill to do so only for this particular usage, but perhaps
there are other places where if would be an improvement?

-- 
Alexander S. Klenin
Insight Experts Ltd.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Mon Sep 3 19:59:48 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.