[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Command to copy a single file

From: Daniel Posey <daniel_posey_at_hotmail.com>
Date: 2007-05-17 09:47:18 CEST

----- Original Message -----
From: "Stefan Küng" <tortoisesvn@gmail.com>
To: <users@tortoisesvn.tigris.org>

Daniel Posey wrote:
> > But I also get SVN Move and SVN Copy when dragging a file not in a
> > working
> > copy! If i try it anyway, I get "<path> is not a working copy".

> Fixed both in revision 9427.

ContextMenu.cpp lines 730 and 734 (identical conditions for showing
ShellMenuDropCopyRename and ShellMenuDropMoveRename)

In Rev9395 you have:
 if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
(ITEMIS_INSVN|ITEMIS_ONLYONE))&&((~itemStates) & ITEMIS_ADDED))

Of course, this tests:
(itemStates & (ITEMIS_INSVN|ITEMIS_ONLYONE)) != 0

You really meant to test:
(itemStates & (ITEMIS_INSVN|ITEMIS_ONLYONE)) ==
(ITEMIS_INSVN|ITEMIS_ONLYONE)

So yesterday in Rev9427 you attempt this fix by dropping ITEMIS_ONLYONE:
 if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
ITEMIS_INSVN)&&((~itemStates) & ITEMIS_ADDED))

This would be an OK feature to allow multiple files to be renamed. But,
TortoiseProc.cpp ignores the /rename switch if more than one filename is
supplied.

So the corrected form for both lines would be:
 if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
ITEMIS_INSVN)&&(itemStates & ITEMIS_ONLYONE)&&((~itemStates) &
ITEMIS_ADDED))

DP

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu May 17 09:47:44 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.