[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Command to copy a single file

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-05-17 10:58:37 CEST

Daniel Posey wrote:

> ContextMenu.cpp lines 730 and 734 (identical conditions for showing
> ShellMenuDropCopyRename and ShellMenuDropMoveRename)
>
>
> In Rev9395 you have:
> if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
> (ITEMIS_INSVN|ITEMIS_ONLYONE))&&((~itemStates) & ITEMIS_ADDED))
>
> Of course, this tests:
> (itemStates & (ITEMIS_INSVN|ITEMIS_ONLYONE)) != 0
>
> You really meant to test:
> (itemStates & (ITEMIS_INSVN|ITEMIS_ONLYONE)) ==
> (ITEMIS_INSVN|ITEMIS_ONLYONE)
>
>
> So yesterday in Rev9427 you attempt this fix by dropping ITEMIS_ONLYONE:
> if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
> ITEMIS_INSVN)&&((~itemStates) & ITEMIS_ADDED))
>
> This would be an OK feature to allow multiple files to be renamed. But,
> TortoiseProc.cpp ignores the /rename switch if more than one filename is
> supplied.
>
>
> So the corrected form for both lines would be:
> if ((itemStates & ITEMIS_FOLDERINSVN)&&(itemStates &
> ITEMIS_INSVN)&&(itemStates & ITEMIS_ONLYONE)&&((~itemStates) &
> ITEMIS_ADDED))

You're right of course. I wanted to change TortoiseProc to handle
renames of multiple files, but I don't have the time right now. So I'm
changing the context menus back to only show them when only one item is
selected.
Thanks for noticing.

Committed in revision 9430.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu May 17 10:58:48 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.