[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature request: Warning on get lock

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-05-01 22:44:35 CEST

On Friday 28 April 2006 09:34, Lübbe Onken wrote:
> Hans-Emil wrote:
> > Someone with the power; PPFAI?
> Do you want the power?
> > Or should be better wait until Stefan returns with his verdict?
> No, he can still set the resolution to "won't implement" :-)
> http://tortoisesvn.berlios.de/issues/?do=details&id=246

I've implemented this feature, see attached patch and screenshot.

Before I commit the following needs to be discussed
- The tooltip currently doesn't name the files which are affected which is not
optimal. There are three alternatives: only adjust the tooltip to say "one or
more files", list the affected files in the tooltip or add a column in the
lock dialog. I prefer the last alternative. Comments?
- Where do we place that warning. I've placed it in the top right corner of
the dialog, see screenshot. But I'm not quite happy about it. Maybe we should
resize the list control in the lock dialog, so that it can be placed above
the "Help" button similar to the external warning in the commit dialog.
- the warning currently uses extwarning.gif. I would prefer to rename that
file to warning.gif and also rename IDI_EXTERNALWARNING to IDI_WARNING. The
alternative would be to copy that file and name it lockwarning.gif but that
redundancy is IMHO not needed.


To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Mon May 1 22:46:55 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.