Re: Hide unrelated changed files not working

Tobias Schäfer wrote:
> On Sunday 30 April 2006 00:43, Simon Large wrote:
>> Kazutoshi Satoda wrote:
>>> Simon Large wrote:
>>>> In the Show Log dialog, when the 'Hide unrelated changed paths' box is
>>>> checked or half-checked, *everything* seems to be unrelated. Even if I
>>>> show the log for a single file, that file is always greyed out in the
>>>> bottom pane. Not sure when this stopped working.
>>>>
>>>> Tested on 1.3.3 and 1.4.0.6152
>>> I have found similar problem. When I start the log dialog for an WC
>>> item which URL contains Japanese characters, all paths are shown as
>>> unrelated, even if a path is the item itself. If I start the log
>>> dialog from repo-browser for the same item, paths are shown correctly.
>>>
>>> I am using 1.4.0, Build 6222 - 32 Bit -dev.
>>> Can this help?
>> I think you are onto something here. It seems to happen if there are
>> spaces in the path. It always works OK from repo browser, but from a WC
>> if the selected item contains a space, everything is shown in the log as
>> unrelated. The top level (checkout folder) of the WC doesn't count: that
>> can contain a space, which suggests it is the URL escaping rather than
>> the path itself.
>
> I can confirm that it's the URL escaping. The following patch solves the bug
> for the space in the path. I don't know about the Japanese characters because
> I cannot test it.
>
> I'm not quite sure if this is the right way to fix it.
> Stefan, can you please have a look when you're back again.

There's something not quite right here. The URL we use there is taken
from the working copy (the repository URL assigned with that working
copy file/folder). So it should be escaped already. The first question
should be, why it isn't escaped.

But since that URL obviously can be not escaped, your patch looks right.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org