Re: Feature request: Warning on get lock

On 5/1/06, Tobias Schäfer <tobiasschaefer@gmx.de> wrote:

> I've implemented this feature, see attached patch and screenshot.

Looks good.

> Before I commit the following needs to be discussed
> - The tooltip currently doesn't name the files which are affected which is not
> optimal. There are three alternatives: only adjust the tooltip to say "one or
> more files", list the affected files in the tooltip or add a column in the
> lock dialog. I prefer the last alternative. Comments?

I like the additional column idea best.

> - Where do we place that warning. I've placed it in the top right corner of
> the dialog, see screenshot. But I'm not quite happy about it. Maybe we should
> resize the list control in the lock dialog, so that it can be placed above
> the "Help" button similar to the external warning in the commit dialog.

I don't have any preferences here.

> - the warning currently uses extwarning.gif. I would prefer to rename that
> file to warning.gif and also rename IDI_EXTERNALWARNING to IDI_WARNING. The
> alternative would be to copy that file and name it lockwarning.gif but that
> redundancy is IMHO not needed.

Careful!
Don't rename it to IDI_WARNING (the define at least), because
IDI_WARNING is already defined in the SDK. It's the system define for
the warning icon in the messagbox dialogs.

Other than that, I'm ok with renaming it.

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org