Hi list (Stefan),
while showing my boss how he can get my commits during last month I discovered a little oddity when selecting a start date that is before the last 100 commits. Then I had a look at the online help and came along...
"
5.8.5. Filtering Log Messages
[...]
Note that these filters act on the messages already retrieved.
They do not control downloading of messages from the repository
"
Then I thought "If that is true - Why am I able to select an unretrieved start date?"
Here's a patch which should prevent selecting such out-of-range dates.
Best Regards
Michael
PS: This patch is untested (not even compiled on my machine)
PPS: Also corrects an inconsistency in the docs ('Get All' -> 'Show All')
Index: doc/source/en/tsvn_dug/dug_showlog.xml
===================================================================
--- doc/source/en/tsvn_dug/dug_showlog.xml (revision 4564)
+++ doc/source/en/tsvn_dug/dug_showlog.xml (working copy)
@@ -307,7 +307,7 @@
</para>
<para>
If you want to see <emphasis>all</emphasis> log messages right back
- to revision 1, press <guibutton>Get All</guibutton>.
+ to revision 1, press <guibutton>Show All</guibutton>.
</para>
</sect2>
<sect2 id="tsvn-DUG-showlog-4">
Index: src/TortoiseProc/LogDlg.cpp
===================================================================
--- src/TortoiseProc/LogDlg.cpp (revision 4564)
+++ src/TortoiseProc/LogDlg.cpp (working copy)
@@ -570,12 +570,12 @@
}
m_LogList.SetItemCountEx(m_arShownList.GetCount());
- __time64_t rt = m_tFrom;
- CTime tim(rt);
- m_DateFrom.SetTime(&tim);
- rt = m_tTo;
- tim = rt;
- m_DateTo.SetTime(&tim);
+ CTime timFrom(__time64_t( m_tFrom ));
+ CTime timTo (__time64_t( m_tTo ));
+ m_DateFrom.SetTime (&timFrom);
+ m_DateTo .SetTime (&timTo );
+ m_DateFrom.SetRange(&timFrom, &timFrom);
+ m_DateTo .SetRange(&timFrom, &timFrom);
temp.LoadString(IDS_MSGBOX_OK);
GetDlgItem(IDOK)->SetWindowText(temp);
@@ -2365,12 +2365,12 @@
m_arShownList.RemoveAll();
// reset the time filter too
- __time64_t rt = m_tFrom;
- CTime tim(rt);
- m_DateFrom.SetTime(&tim);
- rt = m_tTo;
- tim = rt;
- m_DateTo.SetTime(&tim);
+ CTime timFrom(__time64_t( m_tFrom ));
+ CTime timTo (__time64_t( m_tTo ));
+ m_DateFrom.SetTime (&timFrom);
+ m_DateTo .SetTime (&timTo );
+ m_DateFrom.SetRange(&timFrom, &timFrom);
+ m_DateTo .SetRange(&timFrom, &timFrom);
for (DWORD i=0; i<m_logEntries.size(); ++i)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Oct 6 17:48:19 2005