Re: [TSVN] [PATCH] Log Message Filtering by Date

Michael Dietschi wrote:

> while showing my boss how he can get my commits during last month I
> discovered a little oddity when selecting a start date that is before
> the last 100 commits. Then I had a look at the online help and came
> along...
>
> "
> 5.8.5. Filtering Log Messages
> [...]
> Note that these filters act on the messages already retrieved.
> They do not control downloading of messages from the repository
> "
>
> Then I thought "If that is true - Why am I able to select an unretrieved
> start date?"
> Here's a patch which should prevent selecting such out-of-range dates.

Committed your patch (with some necessary tweaks) in revision 4582.

> - __time64_t rt = m_tFrom;
> - CTime tim(rt);
> - m_DateFrom.SetTime(&tim);
> - rt = m_tTo;
> - tim = rt;
> - m_DateTo.SetTime(&tim);
> + CTime timFrom(__time64_t( m_tFrom ));
> + CTime timTo (__time64_t( m_tTo ));
> + m_DateFrom.SetTime (&timFrom);
> + m_DateTo .SetTime (&timTo );

This doesn't work, because SetTime() expects const pointers, which
doesn't work with temporary objects (allocated on the stack). So I added
member variables in the class to pass them to SetTime().

> + m_DateFrom.SetRange(&timFrom, &timFrom);
> + m_DateTo .SetRange(&timFrom, &timFrom);

I think SetRange(&timFrom, &timTo) would work much, much better! ;)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org