[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] "diff" command in context menu when selecting an added file

From: SteveKing <stefankueng_at_gmail.com>
Date: 2005-01-06 13:00:03 CET

On Thu, 06 Jan 2005 10:03:54 +0000, Will Dean <svn@indcomp.co.uk> wrote:

> >But then diff viewers start implementing that 'feature' and what then?
> >Users complaining why TSVN doesn't allow it?
>
> I don't think this is worth discussion, if we're going to fix the context
> menu anyway...

That's the whole discussion about: shall we deactivate the menu if
it's a plain "add" or not. I think we should activate it anyway -
TortoiseMerge can handle even that ;)

> >Why don't we use the shell status cache for the context menu too? I
> >mean, if you right-click on an item, it has to be visible in the
> >explorer, which means the overlay/columnhandler status cache most
> >likely already has that status ready!
>
> That's a brilliant idea - and it's bound to speed-up the context menu display.
>
> Do you want to have a go at that, or shall I?

I was planning on changing the Mutex in the shell extension with a
critical section and guard the whole function not just the cache (as
you mentioned in a PM earlier, the way it's done now can cause
crashes). So I'll be changing the shell extension files anyway so I'll
have a look at the changes in the context menu too - otherwise we
might end up with ugly conflicts.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 13:00:54 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.