Re: [TSVN] "diff" command in context menu when selecting an added file

At 13:00 06/01/2005 +0100, you wrote:

>That's the whole discussion about: shall we deactivate the menu if
>it's a plain "add" or not. I think we should activate it anyway -
>TortoiseMerge can handle even that ;)

But if we don't enable Diff unless it's an Add AND the 'Copied' flag is
set, then we will never call a merge program with a missing file.

>I was planning on changing the Mutex in the shell extension with a
>critical section and guard the whole function not just the cache (as
>you mentioned in a PM earlier, the way it's done now can cause
>crashes). So I'll be changing the shell extension files anyway so I'll
>have a look at the changes in the context menu too - otherwise we
>might end up with ugly conflicts.

OK. While you're in there, would it be possible to make GetCachedItem
private to SVNFolderStatus, and only call GetFullStatus from outside
SVNFolderStatus?

That way all the details of cache hitting and missing and building are
encapsulated within SVNFolderStatus, and then consumers of the status
information (there's about to be another one added) won't need to know
anything about the operation of the cache.

I haven't looked in detail at how feasible this is, but I feel that a cache
should be able to answer the single request "Give me the data", rather than
having to be talked-to twice, once to find out if the data's cached and
once to tell it to build. That's how the column provider seems to work,
anyway.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 13:19:20 2005