Re: [TSVN] "diff" command in context menu when selecting an added file

At 10:57 06/01/2005 +0100, you wrote:

>I wasn't talking about how to check if the menu item should be shown.
>The 'diff' command in TSVN uses GetPristinePath() to get the file to
>which the selected file should be compared to. Now, does
>GetPristinePath() return the filepath to the sourcefile before the
>copy/move? Or does it return an empty path?

It appears that it returns the path which you'd expect, even if the file
doesn't exist yet. When you've copied a committed file, the new base file
*does* exist.

>But then diff viewers start implementing that 'feature' and what then?
>Users complaining why TSVN doesn't allow it?

I don't think this is worth discussion, if we're going to fix the context
menu anyway...

>Why don't we use the shell status cache for the context menu too? I
>mean, if you right-click on an item, it has to be visible in the
>explorer, which means the overlay/columnhandler status cache most
>likely already has that status ready!

That's a brilliant idea - and it's bound to speed-up the context menu display.

Do you want to have a go at that, or shall I?

I shall chuck away the hack I was attempting on SVNStatus, which was ugly
and wasn't going to work.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 11:04:56 2005