[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default"

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-08-01 16:02:16 CEST

Bernd Rinn <bernd@sdf.lonestar.org> wrote on 08/01/2005 09:49:20 AM:

> It turned out to be pretty simple to implement that on top of Eugene's
> patch. I have attached the patch (to be applied to HistoryView.java).
>
> Just one comment regarding the patch and two general question:
>
> * I would suggest renaming the actions toggleTextWrapAction,
> toggleTextAction, and toggleListAction to something more descriptive,
e.g.
> toggleTextWrapAction -> toggleWrapCommentsAction,
> toggleTextAction -> toggleShowComments,
> toggleListAction -> toggleShowAffectedPathsAction.

Eugene, can you try to incorporate this stuff into your patch? I would
still like to see this part of the patch separated from the rest.

> * What's the preferred way of submitting subclipse patches: sending them
> do the dev mailing list or putting them into the issue tracker?

I like to see it go to the issue tracker because email can mess up the
patch. Of course, you can always post something to dev@ after adding an
item to the issue tracker.

> * Is there a general rule for Eclipse (or more specifically Subclipse)
> when to put some persistent setting into the preferences dialog and when
> to keep them 'local' to e.g. a view?

I personally like to avoid preferences, and even choices, as much as
possible. A case like this is a perfect example. There is really no need
for a preference (once Eugene's patch) is implemented. If the affected
paths are not being shown in the view, due to the toggle, then it makes
perfect sense to not be retrieving them via the API. There is really no
need to even offer a choice. The user essentially made the choice when
they decided to hide that part of the view.

Thanks

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Tue Aug 2 00:02:16 2005

This is an archived mail posted to the Subclipse Dev mailing list.