[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default"

From: Eugene Kuleshov <eu_at_javatx.com>
Date: 2005-08-18 23:47:13 CEST

Bernd Rinn wrote:

>>Bernd Rinn <bernd@sdf.lonestar.org> wrote on 08/01/2005 09:49:20 AM:
>>
>>
>>
>>>It turned out to be pretty simple to implement that on top of >Eugene's
>>>patch. I have attached the patch (to be applied to HistoryView.java).
>>>
>>>Just one comment regarding the patch and two general question:
>>>
>>>* I would suggest renaming the actions toggleTextWrapAction,
>>>toggleTextAction, and toggleListAction to something more descriptive,
>>>
>>>
>>e.g.
>>
>>
>>> toggleTextWrapAction -> toggleWrapCommentsAction,
>>> toggleTextAction -> toggleShowComments,
>>> toggleListAction -> toggleShowAffectedPathsAction.
>>>
>>>
>>Eugene, can you try to incorporate this stuff into your patch? I would
>>still like to see this part of the patch separated from the rest.
>>
>>
>>
>>>* What's the preferred way of submitting subclipse patches: sending
>>>them
>>>do the dev mailing list or putting them into the issue tracker?
>>>
>>>
>>>
>>I like to see it go to the issue tracker because email can mess up the
>>patch. Of course, you can always post something to dev@ after adding >an
>>item to the issue tracker.
>>
>>
>Sorry, I am not allowed to add a comment to issue #349, so I am sending
>an email anyway.
>
>Eugene doesn't seem to have time to prepare the HistoryView patch. Since
>I would like to see that functionality in 0.9.33, I have prepared a
>patch that applies cleanly against revision 1555 and that doesn't
>contain the context menu for the "affected paths" table (which takes
>quite long to appear).
>
  Thanks for doing this. I'm still catching up with some stuff after my
vacation.

>I've tested the patch and it works fine for me.
>Could anyone else give it a test?
>
>
  I'll give it a try tonight.

  regards,
  Eugene
Received on Fri Aug 19 07:47:13 2005

This is an archived mail posted to the Subclipse Dev mailing list.