[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: New Subclipse Release coming

From: Magnus Naeslund(t) <mag_at_fbab.net>
Date: 2005-04-06 03:36:46 CEST

(removed the CC, it seems the mailinglist rejects CC:s?)

Mark Phippard wrote:
>
> I was hoping that Panagiotis would review it. Also, he has commit
> authority so he can just commit both of them whenever he feels like it. As
> long as you both test that your patch does nothing to make Eclipse 3.0.x
> stop working, I do not have any objections.
>

Here's the polished auto-add patch up for review:

http://subclipse.tigris.org/nonav/issues/showattachment.cgi/39/subclipse-autoadd-rc3.diff

It's on top of Panagiotis auto-share work, but a bit more simplified
since my latest patch. Easier to follow too, hopefully.

I've tested both functionalities after my changes, and they work fine.

I've also tested with Eclipse 3.0.2 and everything seems to work fine as
far as I can tell. It just doesn't have the new functionality since it
doesn't support the 3.1 style metadata tracking.

Eyeing thru the code I can't find anything in my new code that could be
even touched by running 3.0.x except the simple dialog hooking stuff.
But since nothing is using that except my code (that is dead in 3.0.x)
that won't cause any problems.

My evaluation is that it won't affect anyone except 3.0.x subclipse
developers that will see "Unknown attribute 'metaFilePaths'" in plugin.xml.

So if Panagiotis is happy, he can apply it...

Regards,
Magnus
Received on Wed Apr 6 11:36:46 2005

This is an archived mail posted to the Subclipse Dev mailing list.