Re: [PATCH] Re: New Subclipse Release coming

[Forgot to CC the list]

Panagiotis Korros said:
> I gave your patch a quick look. It seems ok.
>
> The only think I noticed is that you have ui code residing in the core
> plugin.
>
> The usual eclipse conventions are never to have ui in the core plugin so
> as
> the core can run headless.
>
> I don't know if that is a requirement for subclipse. We may already have
> ui
> code in the core plugin.
>

If you mean the ISimpleDialogHelper hooking code, i regard it as OK since
it's the ui code calling core when hooking it, not the other way around.
Also it is done via an interface, so core never really depends on ui.

If my code is run headless, it will reshedule the job 10 times (over 10
seconds, see that AutoAddJob code) and then skip the auto-add, since we
couldn't get the users OK on adding it.

This was already done in a similiar manner for asking passwords (see
SVNProviderPlugin#setSvnPromptUserPassword/getSvnPromptUserPassword) but
if core would really need a password operations would fail ofcourse.

I was thinking of porting the password dialog code to my hooking interface
later to remove code duplication.

Does this sound OK?

Regards,
Magnus
Received on Wed Apr 6 21:34:00 2005