[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

3.1m6 woes (was: New Subclipse Release coming)

From: Magnus Naeslund(t) <mag_at_fbab.net>
Date: 2005-04-06 02:54:45 CEST

This might be save us from user whining to have this fix in next version
of subclipse.

I see a problem affecting compability with 3.1M6 that maybe we should
fix. It would be safe since M6 is an API freeze release:

TeamAction#getProviderMapping(void) convenience method was removed.
But since the old code looked like this:

protected Hashtable getProviderMapping() {
        return getProviderMapping(getSelectedResources());
}

I just onelinered the two problem classes (AddAction, UnmanageAction).

I've checked 3.0.2 and 3.1M<6 and I can't see any problems with the
attached change.

If you agree, please apply the attached patch to the ui project,
otherwise subclipse won't work in M6.

Regards,
Magnus

Index: src/org/tigris/subversion/subclipse/ui/actions/AddAction.java
===================================================================
--- src/org/tigris/subversion/subclipse/ui/actions/AddAction.java (revision 1308)
+++ src/org/tigris/subversion/subclipse/ui/actions/AddAction.java (working copy)
@@ -47,7 +47,7 @@
                         public void execute(IProgressMonitor monitor) throws InvocationTargetException {
                                 try {
                     // associate the resources with their respective RepositoryProvider
- Hashtable table = getProviderMapping();
+ Hashtable table = getProviderMapping(getSelectedResources());
                                         Set keySet = table.keySet();
                                         monitor.beginTask("", keySet.size() * 1000); //$NON-NLS-1$
                                         monitor.setTaskName(Policy.bind("AddAction.adding")); //$NON-NLS-1$
Index: src/org/tigris/subversion/subclipse/ui/actions/UnmanageAction.java
===================================================================
--- src/org/tigris/subversion/subclipse/ui/actions/UnmanageAction.java (revision 1308)
+++ src/org/tigris/subversion/subclipse/ui/actions/UnmanageAction.java (working copy)
@@ -148,7 +148,7 @@
                         public void execute(IProgressMonitor monitor) throws InvocationTargetException {
                                 try {
                                         // maps the selected resources (projects) to their providers
- Hashtable table = getProviderMapping();
+ Hashtable table = getProviderMapping(getSelectedResources());
                                         Set keySet = table.keySet();
                                         monitor.beginTask("", keySet.size() * 1000); //$NON-NLS-1$
                                         monitor.setTaskName(Policy.bind("Unmanage.unmanaging")); //$NON-NLS-1$
Received on Wed Apr 6 10:54:45 2005

This is an archived mail posted to the Subclipse Dev mailing list.