I gave your patch a quick look. It seems ok.
The only think I noticed is that you have ui code residing in the core
plugin.
The usual eclipse conventions are never to have ui in the core plugin so as
the core can run headless.
I don't know if that is a requirement for subclipse. We may already have ui
code in the core plugin.
On Apr 6, 2005 3:03 AM, Magnus Naeslund(t) <mag@fbab.net> wrote:
>
> Mark Phippard wrote:
> >
> > I was hoping that Panagiotis would review it. Also, he has commit
> > authority so he can just commit both of them whenever he feels like it.
> As
> > long as you both test that your patch does nothing to make Eclipse 3.0.x
> > stop working, I do not have any objections.
> >
>
> Here's the polished auto-add patch up for review:
>
>
> http://subclipse.tigris.org/nonav/issues/showattachment.cgi/39/subclipse-autoadd-rc3.diff
>
> It's on top of Panagiotis auto-share work, but a bit more simplified
> since my latest patch. Easier to follow too, hopefully.
>
> I've tested both functionalities after my changes, and they work fine.
>
> I've also tested with Eclipse 3.0.2 and everything seems to work fine as
> far as I can tell. It just doesn't have the new functionality since it
> doesn't support the 3.1 style metadata tracking.
>
> Eyeing thru the code I can't find anything in my new code that could be
> even touched by running 3.0.x except the simple dialog hooking stuff.
> But since nothing is using that except my code (that is dead in 3.0.x)
> that won't cause any problems.
>
> My evaluation is that it won't affect anyone except 3.0.x subclipse
> developers that will see "Unknown attribute 'metaFilePaths'" in plugin.xml
> .
>
> So if Panagiotis is happy, he can apply it...
>
> Regards,
> Magnus
>
>
--
Take back the web http://www.getfirefox.com
Received on Wed Apr 6 16:49:17 2005