Re: [PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com> writes:

>> + SVN_ERR(create_greek_fs(&fs, &newrev, "obtain-write-lock-failure-test",
>> + opts, pool));
>> + SVN_ERR(svn_fs_create_access(&access, "bubba", pool));
>> + SVN_ERR(svn_fs_set_access(fs, access));
>
> Should probably be named "test-obtain-write-lock-failure".
>
> + /* Make a read only 'write-lock' file. This prevents any write operations
> + from being executed. */
> + SVN_ERR(svn_io_set_file_read_only("obtain-write-lock-failure-test/write-lock",
> + TRUE, pool));
>
> I suppose there is no reason to use ignore_enoent = TRUE here, right? The
> 'write-lock' is always there and if it is not, the test shouldn't give a
> false positive.

I tweaked these parts of the test in r1657530.

Regards,
Evgeny Kotkov
Received on 2015-02-05 12:16:41 CET