[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1656893 - in /subversion/trunk/subversion: svnsync/sync.c tests/cmdline/svnsync_tests_data/mergeinfo-contains-r0.dump tests/cmdline/svnsync_tests_data/mergeinfo-contains-r0.expected.dump

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 5 Feb 2015 15:45:10 +0300

On 4 February 2015 at 20:45, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> So we're on the third version of the code and third version of the test, for a
> tiny edge-case feature. Clearly it's fragile. I had a bad feeling about writing it
> this way in the first place.
I had the same feelings when were reviewing backport nomination in 1.8.x.

I wonder why you duplicated code that parses svn:mergeinfo instead of
using svn_mergeinfo_parse() ? I mean:
1. Parse svn:mergeinfo using svn_mergeinfo_parse()
2. For every path remove zero revision using svn_rangelist_remove()
3. Build new svn:mergeinfo using svn_mergeinfo_to_string()

-- 
Ivan Zhakov
Received on 2015-02-05 13:46:51 CET

This is an archived mail posted to the Subversion Dev mailing list.