[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock()

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 05 Feb 2015 10:50:10 +0000

Sergey Raevskiy <sergey.raevskiy_at_visualsvn.com> writes:

> I've attached the patch with crashing test and simple fix for this issue.
>
> Log message:
> [[[
> Fix possible crash in svn_fs_fs__lock() / svn_fs_fs__unlock().
>
> * subversion/subversion/tests/libsvn_fs/locks-test.c
> (obtain_write_lock_failure_test): New; test for the issue.
>
> * subversion/subversion/libsvn_fs_fs/lock.c
> (lock_body,
> svn_fs_fs__lock): Initialize the lb.infos field before calling to
> svn_fs_fs__with_write_lock().
> (unlock_body,
> svn_fs_fs__unlock): Same.
>
> Patch by: Sergey Raevskiy <sergey.raevskiy{_AT_}visualsvn.com>
> ]]]

You missed a second unlock allocation in unlock_single. I fixed that
and applied it in r1657525. Thanks!

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-02-05 11:50:40 CET

This is an archived mail posted to the Subversion Dev mailing list.