Re: [PATCH] add 'svn:use-commit-times' property

Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 23:13:54 +0900:
>>> " before it is modified. Makes the working copy file read-only¥n"
>>> " when it is not locked. Use 'svn propdel svn:needs-lock PATH...'¥n"
>>> " to clear.¥n"
>>> + " svn:use-commit-times - If present, make the timestamp of the file¥n"
>>> + " to commit time. Use 'svn propdel svn:use-commit-times PATH...' to clear.¥n"
>>> "¥n"
>>> " Subversion recognizes the following special versioned properties on a¥n"
>>> " directory:¥n"
>>
>> Encoding problem? I see a Yen symbol where a backslash should be.
>
> On Japanse version of Windows (SJIS), Yen and backslash are same symbol.
> What do you see in the attached file, not inline text?

I tried two versions of mutt and each of them showed something gelse.

I tried to decode the attachment manually, with:

    openssl base64 -d | iconv -f shift_jis -t utf-8 | fgrep 'n"'

and that gives me a Yen symbol.

> Fixed.

Thanks. You still have several places where your code exceeds 80
characters. Otherwise it looks good as far as form is concerned.

I prefer that someone else review the semantics, i.e., the actual
feature being added.

Cheers,

Daniel
Received on 2013-08-08 16:27:08 CEST